Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: ui: Transaction Details page on its own route #73737

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 13, 2021

Backport 1/1 commits from #73198 on behalf of @maryliag.

/cc @cockroachdb/release


Previously, transaction details was using the same route
as transactions list, so it wasn't possible to share a link
for a specific transaction details and also only the content
inside the tabs of SQL Activity were being replaced instead
of the entire page.
This commit change Transaction Details to its own route and
separate the creation on a different file from TransactionsPage.

Fixes #73200

Before
https://user-images.githubusercontent.com/1017486/143654072-5180bebd-6c37-4bf0-bf87-9757e29a1783.mov

After
https://user-images.githubusercontent.com/1017486/143655627-485f9768-0671-4a55-9a08-e52a1021deca.mov

Release note: None


Release justification: Category 4

Previously, transaction details was using the same route
as transactions list, so it wasn't possible to share a link
for a specific transaction details and also only the content
inside the tabs of SQL Activity were being replaced instead
of the entire page.
This commit change Transaction Details to its own route and
separate the creation on a different file from TransactionsPage.

Fixes #73200

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-73198 branch from 5d698a1 to 4d8a901 Compare December 13, 2021 15:07
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 13, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 13, 2021
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from a team December 13, 2021 15:08
Copy link
Contributor

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @Azhng, @lindseyjin, and @maryliag)

@maryliag maryliag merged commit 60033f6 into release-21.2 Dec 13, 2021
@maryliag maryliag deleted the blathers/backport-release-21.2-73198 branch December 13, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants