Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transaction details as it own route #73200

Closed
maryliag opened this issue Nov 26, 2021 · 0 comments · Fixed by #73198
Closed

transaction details as it own route #73200

maryliag opened this issue Nov 26, 2021 · 0 comments · Fixed by #73198
Assignees
@maryliag
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@maryliag
Copy link
Contributor

Follow up to #66052
The Transactions Details page is using the same route and component for Transactions Page. We want the transactions details to be its own route so it can be easy shared and also the full page is loaded with the details and not just the content inside the Transaction tab on the SQL Activity page.
The transactions details should follow the same behaviour as Statements Details

before_txn_details.mov
@maryliag maryliag added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Nov 26, 2021
@maryliag maryliag self-assigned this Nov 26, 2021
@maryliag maryliag mentioned this issue Nov 26, 2021
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Nov 26, 2021
@maryliag
ui: Transaction Details page on its own route
bdcd17c 
Previously, transaction details was using the same route
as transactions list, so it wasn't possible to share a link
for a specific transaction details and also only the content
inside the tabs of SQL Activity were being replaced instead
of the entire page.
This commit change Transaction Details to its own route and
separete the creation on a different file from TransactionsPage.

Fixes cockroachdb#73200

Release note: None
maryliag added a commit to maryliag/cockroach that referenced this issue Nov 29, 2021
@maryliag
ui: Transaction Details page on its own route
223d9ee 
Previously, transaction details was using the same route
as transactions list, so it wasn't possible to share a link
for a specific transaction details and also only the content
inside the tabs of SQL Activity were being replaced instead
of the entire page.
This commit change Transaction Details to its own route and
separate the creation on a different file from TransactionsPage.

Fixes cockroachdb#73200

Release note: None
maryliag added a commit to maryliag/cockroach that referenced this issue Nov 29, 2021
@maryliag
ui: Transaction Details page on its own route
4ced2a1 
Previously, transaction details was using the same route
as transactions list, so it wasn't possible to share a link
for a specific transaction details and also only the content
inside the tabs of SQL Activity were being replaced instead
of the entire page.
This commit change Transaction Details to its own route and
separate the creation on a different file from TransactionsPage.

Fixes cockroachdb#73200

Release note: None
craig bot pushed a commit that referenced this issue Dec 8, 2021
@maryliag
Merge #73198
ec13853 
73198: ui: Transaction Details page on its own route r=maryliag a=maryliag

Previously, transaction details was using the same route
as transactions list, so it wasn't possible to share a link
for a specific transaction details and also only the content
inside the tabs of SQL Activity were being replaced instead
of the entire page.
This commit change Transaction Details to its own route and
separate the creation on a different file from TransactionsPage.

Fixes #73200

Before
https://user-images.githubusercontent.com/1017486/143654072-5180bebd-6c37-4bf0-bf87-9757e29a1783.mov

After
https://user-images.githubusercontent.com/1017486/143655627-485f9768-0671-4a55-9a08-e52a1021deca.mov


Release note: None

Co-authored-by: Marylia Gutierrez <[email protected]>
@craig craig bot closed this as completed in 775377d Dec 8, 2021
blathers-crl bot pushed a commit that referenced this issue Dec 13, 2021
@maryliag
ui: Transaction Details page on its own route
4d8a901 
Previously, transaction details was using the same route
as transactions list, so it wasn't possible to share a link
for a specific transaction details and also only the content
inside the tabs of SQL Activity were being replaced instead
of the entire page.
This commit change Transaction Details to its own route and
separate the creation on a different file from TransactionsPage.

Fixes #73200

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: Transaction Details page on its own route maryliag/cockroach
1 participant
@maryliag