opt: minor optbuilder improvements related to assignment casts #73650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, optbuilder relied on matching column names to validate that mutations do not explicitly write to `GENERATED ALWAYS AS IDENTITY` columns. There are no known bugs caused by this, but relying on column names can be brittle. This commit updates the logic to use ordinals of columns within their table instead. Release note: None
Release note: None
|
This change is |
RaduBerinde
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Needs a make bazel-generate
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ZhouXing19)
Creation of invalid assignment cast errors has been abstracted to a helper function for reuse for other mutations in a future commit. Release note: None
mgartner
force-pushed
the
simplify-optbuilder-update-logic
branch
from
660f4f7 to
f86da8b
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt: do not rely on column names for GENERATED ALWAYS AS IDENTITY checks
Previously, optbuilder relied on matching column names to validate that
mutations do not explicitly write to
GENERATED ALWAYS AS IDENTITYcolumns. There are no known bugs caused by this, but relying on column
names can be brittle. This commit updates the logic to use ordinals of
columns within their table instead.
Release note: None
opt: simplify optbuilder update logic
Release note: None
opt: simplify assignment cast logic for inserts
Creation of invalid assignment cast errors has been abstracted to a
helper function for reuse for other mutations in a future commit.
Release note: None