ui: save sort on cache for Sessions page #72893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a sort selection was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adressed cockroachdb#68199 Release note: None
Previously, a sort selection was not maintained when the page change (e.g. coming back from Session details). This commits saves the selected value to be used. Partially adressed cockroachdb#68199 Release note: None
|
This change is |
matthewtodd
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a sort selection was not maintained when
the page change (e.g. coming back from Sessions details).
This commits saves the selected value to be used.
Partially adresses #68199
Check only second commit, the first being reviewed at #72882
Release note: None