ui: save sort on cache for Transaction page #72882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, a sort selection was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adressed cockroachdb#68199 Release note: None
maryliag
force-pushed
the
cache-selection
branch
from
ee1e44b to
73bae4b
Compare
matthewtodd
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
|
bors r+ |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2021
72705: sql: miscellaneous cleanup r=yuzefovich a=yuzefovich **sql: don't make a redundant copy of the SetupFlowRequest for local flow** We can just use the setup request directly since all remote requests (if any) did make copies of the original request. Release note: None **colbuilder: don't create a copy of the eval context in most cases** Previously, on every `NewColOperator` call we would create a copy of the eval context. This was copied over from the row engine where making a copy was needed since the row-by-row processors use `ProcOutputHelper` which might modify the eval context when evaluating the expresssions. In the vectorized engine we almost never modify the eval context, so there is no reason to make a copy. Release note: None **colflow: minor optimization to the setup of inputs** Release note: None **colcontainer: make ReuseCache the default cache mode** Previously, the uninitialized disk queue cache mode was the mode that allowed the intertwined calls to Enqueue and Dequeue. However, such mode of operation is only used by the hash routers and the buffered windower, so this commit switches the uninitialized mode to be the "reuse cache" mode (which is used by most components). This commit additionally cleans up the way the mode is updated. Release note: None **colexecargs: remove no longer useful testing knob** This commit removes a testing knob that tells the colbuilder to use a streaming memory account for the buffering operations. The idea behind this knob was to reduce the boilerplate of managing the memory monitoring infrastructure in tests, and with the recent cleanup in that area it is now easy to do properly. Thus, the knob seems no longer needed and is now removed. Release note: None **colbuilder: instantiate a streaming allocator lazily** Release note: None 72893: ui: save sort on cache for Sessions page r=maryliag a=maryliag Previously, a sort selection was not maintained when the page change (e.g. coming back from Sessions details). This commits saves the selected value to be used. Partially adresses #68199 Check only second commit, the first being reviewed at #72882 Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a sort selection was not maintained when
the page change (e.g. coming back from Transaction details).
This commits saves the selected value to be used.
Partially adresses #68199
Release note: None