Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: allow linting a single package #72334

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

rickystewart
Copy link
Collaborator

Tie into the lint test's support for specifiying PKG in the
environment.

Closes #72093.

Release note: None

Tie into the `lint` test's support for specifiying `PKG` in the
environment.

Closes cockroachdb#72093.

Release note: None
@rickystewart rickystewart requested a review from a team as a code owner November 2, 2021 18:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Nov 3, 2021

Build failed (retrying...):

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

If you don't feel like carrying around this code, it looks like PKG=pkg/ccl/backupccl/ ./dev lint would work so we could document that and call it a day, but I think this is more in line with the other dev commands.

@craig
Copy link
Contributor

craig bot commented Nov 3, 2021

Build succeeded:

@craig craig bot merged commit 5afb282 into cockroachdb:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: ability to run lint on an individual package
4 participants