Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: ability to run lint on an individual package #72093

Closed
stevendanna opened this issue Oct 28, 2021 · 0 comments · Fixed by #72334
Closed

dev: ability to run lint on an individual package #72093

stevendanna opened this issue Oct 28, 2021 · 0 comments · Fixed by #72334
Assignees
@rickystewart
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@stevendanna
Copy link
Collaborator

stevendanna commented Oct 28, 2021 •
edited by rickystewart
Loading

The Makefile based build system allows you to run the linters on a particular package using the PKG variable:

make lint PKG=./pkg/ccl/changefeedccl

It would be useful if dev could do this as well. The lint tests are very slow and it is pretty useful to be able to run them on just the packages you changed.

Epic CRDB-8036
@stevendanna stevendanna added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Oct 28, 2021
@rickystewart rickystewart self-assigned this Nov 1, 2021
@rickystewart rickystewart mentioned this issue Nov 2, 2021
Merged
craig bot pushed a commit that referenced this issue Nov 3, 2021
@jaylim-crl @rickystewart
Merge #72277 #72334
5afb282 
72277: ccl/sqlproxyccl: provide hints to the user whenever params parsing fails r=JeffSwenson,rafiss a=jaylim-crl

Previously, whenever params parsing fails during connection startup, an error
message is returned without any hints. Users often get confused on what to
do next as the message can be ambiguous and provide no action items. This
led to a lot of confusion among end users connecting through the sqlproxy,
which can be seen in the recent posts in community forums.

This commit updates the error messages to also return hints, and provide users
with more information. At the same time, we also relabeled "cluster name" to
"cluster identifier", which correctly reflects the format that we're using at
the moment: <cluster name>-<tenant ID>.

Release note: None

72334: dev: allow linting a single package r=rail a=rickystewart

Tie into the `lint` test's support for specifiying `PKG` in the
environment.

Closes #72093.

Release note: None

Co-authored-by: Jay <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in 5b13230 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickystewart rickystewart

Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev: allow linting a single package rickystewart/cockroach
2 participants
@stevendanna @rickystewart