workload/tpcc: check the 90th percentile instead of the .9th #72285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hdrhistogram API was misleading. It expected a percentile for a quantile calculation. All-in-all it appears the author of that library had percentile and quantile confused. At some point in the last year, somebody did add a `ValueAtPercentile` method which has the identical behavior as `ValueAtQuantile`. See https://github.com/cockroachdb/vendored/blob/5b815c7d468d59337db2c742373183af5525e729/github.com/codahale/hdrhistogram/hdr.go#L241-L259 Fixes cockroachdb#72282. Release note: None
|
This change is |
nvanbenschoten
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
|
TFTR! bors r=nvanbenschoten |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hdrhistogram API was misleading. It expected a percentile for a quantile
calculation. All-in-all it appears the author of that library had percentile
and quantile confused. At some point in the last year, somebody did add a
ValueAtPercentilemethod which has the identical behavior asValueAtQuantile.See https://github.com/cockroachdb/vendored/blob/5b815c7d468d59337db2c742373183af5525e729/github.com/codahale/hdrhistogram/hdr.go#L241-L259
Fixes #72282.
Release note: None