Merge #72285 #72295

72285: workload/tpcc: check the 90th percentile instead of the .9th r=nvanbenschoten a=ajwerner The hdrhistogram API was misleading. It expected a percentile for a quantile calculation. All-in-all it appears the author of that library had percentile and quantile confused. At some point in the last year, somebody did add a `ValueAtPercentile` method which has the identical behavior as `ValueAtQuantile`. See https://github.com/cockroachdb/vendored/blob/5b815c7d468d59337db2c742373183af5525e729/github.com/codahale/hdrhistogram/hdr.go#L241-L259 Fixes #72282. Release note: None 72295: sqlsmith: don't use crdb_internal.reset_index_usage_stats r=yuzefovich a=yuzefovich Fixes: #72259. Release note: None Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
cockroachdb · Nov 1, 2021 · ce622df · ce622df
3 parents 039ed5f + 0360326 + e7320e3
commit ce622df
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/internal/sqlsmith/schema.go b/pkg/internal/sqlsmith/schema.go
@@ -493,6 +493,7 @@ var functions = func() map[tree.FunctionClass]map[oid.Oid][]function {
 			"crdb_internal.unsafe_",
 			"crdb_internal.create_join_token",
 			"crdb_internal.reset_multi_region_zone_configs_for_database",
+			"crdb_internal.reset_index_usage_stats",
 		} {
 			skip = skip || strings.Contains(def.Name, substr)
 		}

diff --git a/pkg/workload/tpcc/result.go b/pkg/workload/tpcc/result.go
@@ -192,7 +192,7 @@ func (r *Result) FailureError() error {
 		if !exists {
 			return errors.Errorf("no %v data exists", query)
 		}
-		if v := time.Duration(h.ValueAtQuantile(.9)); v > max90th {
+		if v := time.Duration(h.ValueAtQuantile(90)); v > max90th {
 			err = errors.CombineErrors(err,
 				errors.Errorf("90th percentile latency for %v at %v exceeds passing threshold of %v",
 					query, v, max90th))