Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix import roachtest #72279

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

adityamaru
Copy link
Contributor

This change fixes the import roachtest to switch to the
csv database before creating the table and importing into
it. This broke when we switched the roachtest to use
IMPORT INTO from IMPORT CREATE USING in #72097.

Fixes: #68037

Release note: None

This change fixes the import roachtest to switch to the
`csv` database before creating the table and importing into
it. This broke when we switched the roachtest to use
IMPORT INTO from IMPORT CREATE USING in cockroachdb#72097.

Fixes: cockroachdb#68037

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I suppose we don't need semi-colons for sql we aren't entering at the terminal, but this keeps it consistent with the rest of the function. :D

@adityamaru
Copy link
Contributor Author

TFTR!

bors r=stevendanna

@craig
Copy link
Contributor

craig bot commented Nov 1, 2021

Build succeeded:

@craig craig bot merged commit 1f705cc into cockroachdb:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: import/tpch/nodes=8 failed
3 participants