Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest,workload: switch non-bundle IMPORT to IMPORT INTO #72097

Merged

Conversation

adityamaru
Copy link
Contributor

This change switches all uses of the soon to be deleted non-bundle IMPORT TABLE, to IMPORT INTO in the roachtest and workload packages.

Informs: #70050

Release note: None

@adityamaru adityamaru requested review from dt and a team October 28, 2021 15:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru adityamaru removed the request for review from a team October 28, 2021 15:12
@adityamaru adityamaru force-pushed the switch-workload-roachtest-import-into branch from 4c95b81 to 1b4f988 Compare October 28, 2021 15:18
@adityamaru
Copy link
Contributor Author

bazel failure seems unrelated

bors r=dt

@craig
Copy link
Contributor

craig bot commented Oct 28, 2021

Build succeeded:

@craig craig bot merged commit 2c82a27 into cockroachdb:master Oct 28, 2021
@adityamaru adityamaru deleted the switch-workload-roachtest-import-into branch October 29, 2021 14:47
adityamaru added a commit to adityamaru/cockroach that referenced this pull request Nov 1, 2021
This change fixes the import roachtest to switch to the
`csv` database before creating the table and importing into
it. This broke when we switched the roachtest to use
IMPORT INTO from IMPORT CREATE USING in cockroachdb#72097.

Fixes: cockroachdb#68037

Release note: None
craig bot pushed a commit that referenced this pull request Nov 1, 2021
72002: pgwire: add a test for server aborting on repeated errors r=otan a=rafiss

This adds a test for a recent commit that changed the pgwire loop to
give up if it saw an error repeatedly. I added a testing knob to inject
an error, and did a small refactor so that errors are handled
consistently. Previously, some error handling would only happen for
"MessageTooBig" errors.

Release note: None

72279: roachtest: fix import roachtest r=stevendanna a=adityamaru

This change fixes the import roachtest to switch to the
`csv` database before creating the table and importing into
it. This broke when we switched the roachtest to use
IMPORT INTO from IMPORT CREATE USING in #72097.

Fixes: #68037

Release note: None

Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Co-authored-by: Aditya Maru <adityamaru@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants