cmd/roachtest: skip clearrange/zfs/* tests #72044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bananabrick
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @bananabrick and @nicktrav)
-- commits, line 4 at r1:
Does it fail everytime? Afaik, there's failure once every couple of runs.
The clearrange tests occasionally fail when run with a ZFS filesystem. Given that wider ZFS support is minimal, disable these tests until time can be devoted to investigating the cause of the failures. Release note: None.
nicktrav
force-pushed
the
nickt.disable-clearrange
branch
from
a54372f to
00f125f
Compare
nicktrav
commented
Oct 27, 2021
There was a problem hiding this comment.
Dismissed @bananabrick from a discussion.
Reviewable status:
Previously, bananabrick (Arjun Nair) wrote…
Does it fail everytime? Afaik, there's failure once every couple of runs.
Perhaps "consistently" isn't the right word. I'll amend.
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clearrange tests consistently fail when run with a ZFS filesystem.
Given that wider ZFS support is minimal, disable these tests until time
can be devoted to investigating the cause of the failures.
Release note: None.