Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: unskip clearrange/zfs tests #74708

Closed
nicktrav opened this issue Jan 11, 2022 · 3 comments · Fixed by #106858
Closed

storage: unskip clearrange/zfs tests #74708

nicktrav opened this issue Jan 11, 2022 · 3 comments · Fixed by #106858
Assignees
@itsbilal
Labels
C-investigation Further steps needed to qualify. C-label will change. skipped-test T-storage Storage Team

Comments

@nicktrav
Copy link
Collaborator

nicktrav commented Jan 11, 2022 •
edited by cockroach-jira-scripts
Loading

Describe the problem

We previously skipped the clearrange/zfs/** tests (#72044) due to excessive flakiness. This ticket tracks the investigation and re-enabling of these tests.

Jira issue: CRDB-12222
@nicktrav nicktrav added C-investigation Further steps needed to qualify. C-label will change. T-storage Storage Team labels Jan 11, 2022
@nicktrav
Copy link
Collaborator Author

Also skipped on 21.2 - see #74738.

@jbowens
Copy link
Collaborator

jbowens commented Jan 18, 2022

Are we missing a skip somewhere?: #68303 (comment)

@nicktrav
Copy link
Collaborator Author

I think that's for clearrange/checks=true, based on the logs. Unfortunately, it's being grouped under the ZFS ticket.

@itsbilal itsbilal self-assigned this Jul 14, 2023
itsbilal added a commit to itsbilal/cockroach that referenced this issue Jul 14, 2023
@itsbilal
cmd/roachtest: Unskip clearrange/zfs test
4ec4914 
In my test runs, the clearrange/zfs tests reliably pass
now, thanks to improvements over the 1.5+ years since
this test was first skipped. This change unskips the
checks=true/rangeTs=true variant of the test to get
the highest possible test coverage while not significantly
blowing up the list of tests (as rangeTs=false is less supported
going forward anyway).

Epic: none
Fixes cockroachdb#68716.
Fixes cockroachdb#74708.

Release note: None
@itsbilal itsbilal mentioned this issue Jul 14, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 17, 2023
@itsbilal
Merge #106858
6f0fe89 
106858: cmd/roachtest: Unskip clearrange/zfs test r=RaduBerinde a=itsbilal

In my test runs, the clearrange/zfs tests reliably pass now, thanks to improvements over the 1.5+ years since this test was first skipped. This change unskips the checks=true/rangeTs=true variant of the test to get the highest possible test coverage while not significantly blowing up the list of tests (as rangeTs=false is less supported going forward anyway).

Epic: none
Fixes #68716.
Fixes #74708.

Release note: None

Co-authored-by: Bilal Akhtar <[email protected]>
@craig craig bot closed this as completed in 9f7465d Jul 17, 2023
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsbilal itsbilal

Labels
C-investigation Further steps needed to qualify. C-label will change. skipped-test T-storage Storage Team
Projects
No open projects
[Deprecated] Storage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/roachtest: Unskip clearrange/zfs test itsbilal/cockroach
3 participants
@itsbilal @nicktrav @jbowens