release-21.2: ui/cluster-ui: fix routing to statement details page #70804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #70600.
/cc @cockroachdb/release
Partially addresses #68843
Previously, we used two different bases for the statement details page, which
depended on which route parameters were included.
/statements/
was used whenthe app name was included in the path, and otherwise
/statement/
was used.The database name was also optionally included in the path name, further
complicating routing to the statement details page as these optional route
params lead to the need to include all combinations of route parameters for
statement detail paths,
This commit turns all optional route parameters into query string parameters,
removing the necessity for different base paths and route param combinations.
Release note (ui change): For statement detail URLs, the app name and database
name are now query string parameters. The route to statement details is
now definitively
/statement/:implicitTxn/:statement?{queryStringParams}
.e.g.
statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr