Statements Details on the system database is redirecting to the overview page on CC console
#68843
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
GA-blocker
Comments
maryliag
added
the
C-bug
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Sep 22, 2021
Partially addresses cockroachdb#68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr`
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Sep 23, 2021
Partially addresses cockroachdb#68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr`
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Sep 23, 2021
Partially addresses cockroachdb#68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr`
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Sep 24, 2021
Partially addresses cockroachdb#68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr`
|
Hi @maryliag, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Sep 27, 2021
Partially addresses cockroachdb#68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr`
craig bot
pushed a commit
that referenced
this issue
Sep 27, 2021
70600: ui/cluster-ui: fix routing to statement details page r=maryliag a=xinhaoz Partially addresses #68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr` Co-authored-by: Xin Hao Zhang <[email protected]>
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Sep 28, 2021
Partially addresses cockroachdb#68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr`
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Sep 28, 2021
Partially addresses cockroachdb#68843 Previously, we used two different bases for the statement details page, which depended on which route parameters were included. `/statements/` was used when the app name was included in the path, and otherwise `/statement/` was used. The database name was also optionally included in the path name, further complicating routing to the statement details page as these optional route params lead to the need to include all combinations of route parameters for statement detail paths, This commit turns all optional route parameters into query string parameters, removing the necessity for different base paths and route param combinations. Release note (ui change): For statement detail URLs, the app name and database name are now query string parameters. The route to statement details is now definitively `/statement/:implicitTxn/:statement?{queryStringParams}`. e.g. `statement/true/SELECT%20city%2C%20id%20FROM%20vehicles%20WHERE%20city%20%3D%20%241?database=movr&app=movr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On the statements page on CC console, when clicking on statement from the
systemdatabase to see the details, the user is being redirected to the overview pageThe text was updated successfully, but these errors were encountered: