sql: make builtin generators with GeneratorWithExprs safer #70699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Overload.GeneratorWithExprs` field was added in cockroachdb#70115. This commit makes usage of this field safer by introducing the `IsGenerator` method which can be used to determine if an overload is an SRF. This commit also adds guardrails to prevent future issues with `GeneratorWithExprs`in the `ConvertZipArraysToValues` normalization rule. Release note: None
|
This change is |
yuzefovich
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @mgartner)
|
TFTRs! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Overload.GeneratorWithExprsfield was added in #70115. This commitmakes usage of this field safer by introducing the
IsGeneratormethodwhich can be used to determine if an overload is an SRF. This commit
also adds guardrails to prevent future issues with
GeneratorWithExprsin theConvertZipArraysToValuesnormalization rule.Release note: None