sql: add json{,b}_populate_record{,set} #70115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
force-pushed
the
json-to-record
branch
2 times, most recently
from
36f78ec to
a0a6d1a
Compare
ajwerner
reviewed
Sep 14, 2021
jordanlewis
force-pushed
the
json-to-record
branch
from
a0a6d1a to
4d23574
Compare
mgartner
reviewed
Sep 15, 2021
|
|
||
| func (j *jsonPopulateRecordGenerator) Start(_ context.Context, _ *kv.Txn) error { | ||
| if j.target != tree.DNull && j.target.(*tree.DJSON).JSON.Type() != json.ArrayJSONType { | ||
| return pgerror.Newf(pgcode.InvalidParameterValue, "argument of json_populate_recordset must be an array") |
There was a problem hiding this comment.
Should this be moved to makeJSONPopulateRecordSetGenerator?
jordanlewis
force-pushed
the
json-to-record
branch
from
4d23574 to
e3baff8
Compare
mgartner
reviewed
Sep 16, 2021
22 tasks
jordanlewis
force-pushed
the
json-to-record
branch
from
e3baff8 to
6b735ef
Compare
|
Thanks for the suggestions, RFAL |
jordanlewis
force-pushed
the
json-to-record
branch
from
6b735ef to
943f25d
Compare
These generator builtins permit type-safe transformation of JSON to table data. They're added for compatibility with PostgreSQL. Release note (sql change): add the json_populate_record, jsonb_populate_record functions, json_populate_recordset, and jsonb_populate_recordset functions, which transform JSON into row tuples based on the labels in a record type.
jordanlewis
force-pushed
the
json-to-record
branch
from
943f25d to
1bccee6
Compare
|
TFTR! bors r+ |
|
Build failed: |
|
Flake bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
Sep 24, 2021
The `Overload.GeneratorWithExprs` field was added in cockroachdb#70115. This commit makes usage of this field safer by introducing the `IsGenerator` method which can be used to determine if an overload is an SRF. This commit also adds guardrails to prevent future issues with `GeneratorWithExprs`in the `ConvertZipArraysToValues` normalization rule. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 24, 2021
70699: sql: make builtin generators with GeneratorWithExprs safer r=mgartner a=mgartner The `Overload.GeneratorWithExprs` field was added in #70115. This commit makes usage of this field safer by introducing the `IsGenerator` method which can be used to determine if an overload is an SRF. This commit also adds guardrails to prevent future issues with `GeneratorWithExprs`in the `ConvertZipArraysToValues` normalization rule. Release note: None Co-authored-by: Marcus Gartner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #69010
Updates #70037
These generator builtins permit type-safe transformation of JSON to
table data. They're added for compatibility with PostgreSQL.
Release note (sql change): add the json_populate_record,
jsonb_populate_record functions, json_populate_recordset, and
jsonb_populate_recordset functions, which transform JSON into row tuples
based on the labels in a record type.