Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: colexec: adjust the eager cancellation in parallel unordered sync a bit #69991

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 9, 2021

Backport 1/1 commits from #69961 on behalf of @yuzefovich.

/cc @cockroachdb/release


This commit adjusts the logic for swallowing errors in the parallel
unordered synchronizer because of the eager cancellation when the
synchronizer transitions into the draining state to swallow all errors
coming from an input if the input's context has been canceled by the
synchronizer.

Fixes: #69419.

Release note: None

Release justification: update to the new functionality.


Release justification:

This commit adjusts the logic for swallowing errors in the parallel
unordered synchronizer because of the eager cancellation when the
synchronizer transitions into the draining state to swallow all errors
coming from an input if the input's context has been canceled by the
synchronizer.

Release note: None

Release justification: update to the new functionality.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-69961 branch from 9ffb597 to c39a49f Compare September 9, 2021 22:39
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 9, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)

@yuzefovich yuzefovich merged commit 99a4816 into release-21.2 Sep 9, 2021
@yuzefovich yuzefovich deleted the blathers/backport-release-21.2-69961 branch September 9, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants