Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colexec: adjust the eager cancellation in parallel unordered sync a bit #69961

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Sep 9, 2021

This commit adjusts the logic for swallowing errors in the parallel
unordered synchronizer because of the eager cancellation when the
synchronizer transitions into the draining state to swallow all errors
coming from an input if the input's context has been canceled by the
synchronizer.

Fixes: #69419.

Release note: None

Release justification: update to the new functionality.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit adjusts the logic for swallowing errors in the parallel
unordered synchronizer because of the eager cancellation when the
synchronizer transitions into the draining state to swallow all errors
coming from an input if the input's context has been canceled by the
synchronizer.

Release note: None

Release justification: update to the new functionality.
@yuzefovich
Copy link
Member Author

I updated the commit to swallow all errors that occur after the synchronizer transitioned into draining and performed the eager cancellation of the input (as Andrei and I discussed).

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: This seems fine. In fact, it might even be fine ("fine" meaning necessary error information still propagates upward) under more complicated scenarios (writes, non-local flows) assuming that lower layers return the same error again for subsequent calls.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: kv50/enc=false/nodes=4/cpu=96/batch=64 failed [SendError bubbles up]
3 participants