Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: [CRDB-8149] Add CES survey link #68516

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 5, 2021

Backport 3/3 commits from #68429 on behalf of @Santamaura.

/cc @cockroachdb/release


The goal of this PR is to create a basic component that can open a link to the CES feedback survey. The current query parameters that are passed through are clusterId and clusterVersion. If there are any more query parameters that need to be included feel free to comment what they might be. The component will render empty (not able to open the survey) if for some reason we are unable to get the clusterId or clusterVersion values.

Below are some screenshots showcasing the feedback survey link and what the url looks like when opened in a local dev environment:

image

image

This PR is in response to this github issue


Release justification: justification for this backport.

Previously there was no ces survey link
It is important to get feedback from clients
Made a small component that will link to the ces survey

Release note (ui change): A ces survey link component was added
to support being able to get client feedback.
There was no link to the feedback survey
Survey feedback is useful for improving the product
Added a small component to open the survey

Release note (ui change): added component to support survey link
@blathers-crl blathers-crl bot requested a review from a team August 5, 2021 22:23
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-20.2-68429 branch from 03b1755 to 75ae91d Compare August 5, 2021 22:23
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 5, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@nathanstilwell nathanstilwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Santamaura Santamaura merged commit 30dd473 into release-20.2 Aug 27, 2021
@Santamaura Santamaura deleted the blathers/backport-release-20.2-68429 branch August 27, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants