-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-20.2: [CRDB-8149] Add CES survey link #68516
Merged
Santamaura
merged 3 commits into
release-20.2
from
blathers/backport-release-20.2-68429
Aug 27, 2021
Merged
release-20.2: [CRDB-8149] Add CES survey link #68516
Santamaura
merged 3 commits into
release-20.2
from
blathers/backport-release-20.2-68429
Aug 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was no ces survey link It is important to get feedback from clients Made a small component that will link to the ces survey Release note (ui change): A ces survey link component was added to support being able to get client feedback.
There was no link to the feedback survey Survey feedback is useful for improving the product Added a small component to open the survey Release note (ui change): added component to support survey link
blathers-crl
bot
force-pushed
the
blathers/backport-release-20.2-68429
branch
from
August 5, 2021 22:23
03b1755
to
75ae91d
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
koorosh
approved these changes
Aug 9, 2021
nathanstilwell
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #68429 on behalf of @Santamaura.
/cc @cockroachdb/release
The goal of this PR is to create a basic component that can open a link to the CES feedback survey. The current query parameters that are passed through are
clusterId
andclusterVersion
. If there are any more query parameters that need to be included feel free to comment what they might be. The component will render empty (not able to open the survey) if for some reason we are unable to get the clusterId or clusterVersion values.Below are some screenshots showcasing the feedback survey link and what the url looks like when opened in a local dev environment:
This PR is in response to this github issue
Release justification: justification for this backport.