[CRDB-8149] Add CES survey link #68429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was no ces survey link It is important to get feedback from clients Made a small component that will link to the ces survey Release note (ui change): A ces survey link component was added to support being able to get client feedback.
There was no link to the feedback survey Survey feedback is useful for improving the product Added a small component to open the survey Release note (ui change): added component to support survey link
|
This change is |
koorosh
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 3 of 3 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nathanstilwell and @Santamaura)
a discussion (no related file):
with only one minor nit!
pkg/ui/src/views/app/components/feedbackSurveyLink/feedbackSurveyLink.tsx, line 19 at r2 (raw file):
feedbackLink.searchParams.append("clusterVersion", singleVersion); return clusterId && singleVersion ? (
nit. I would suggest to avoid ternary operators in such cases and stick to short circuits evaluation:
if (!clusterId || !singleVersion) {
return ... // <-- exceptional, error conditions, etc
}
return ... // <-- default positive scenario
nathanstilwell
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Reviewable status:
pkg/ui/src/views/app/components/feedbackSurveyLink/feedbackSurveyLink.tsx, line 27 at r2 (raw file):
className="image-container" title="Share Feedback" dangerouslySetInnerHTML={trustIcon(externalLinkIcon)}
🤠
|
bors r+ |
|
Build succeeded: |
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to create a basic component that can open a link to the CES feedback survey. The current query parameters that are passed through are
clusterIdandclusterVersion. If there are any more query parameters that need to be included feel free to comment what they might be. The component will render empty (not able to open the survey) if for some reason we are unable to get the clusterId or clusterVersion values.Below are some screenshots showcasing the feedback survey link and what the url looks like when opened in a local dev environment:
This PR is in response to this github issue