ui: cluster overview node status color mismatch [backport 21.1] #68056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aggreagate rows for multiregion cluster in nodes list table and used single method to calculate status badge for aggregated and single node row. After adding additional node status `NODE_STATUS_DRAINING` we have got enum values overlap and that lead to `LIVE` badge with `warning` color. To fix that, and avoid same problem in future, changes for splitting up aggregated and non aggregated color values were made. Resolves: cockroachdb#67274 Release note(ui): fix color mismatch of node status badge on cluster overview page.
|
This change is |
koorosh
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nathanstilwell and @Santamaura)
Santamaura
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aggreagate rows for multiregion cluster in nodes list
table and used single method to calculate status badge for
aggregated and single node row. After adding additional
node status
NODE_STATUS_DRAININGwe have gotenum values overlap and that lead to
LIVEbadge withwarningcolor.To fix that, and avoid same problem in future, changes for
splitting up aggregated and non aggregated color values
were made.
Resolves: #67274
Release note(ui): fix color mismatch of node status badge
on cluster overview page.