Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: DB Console overview uses incorrect colors for status #67274

Closed
thtruo opened this issue Jul 6, 2021 · 0 comments · Fixed by #68049
Closed

ui: DB Console overview uses incorrect colors for status #67274

thtruo opened this issue Jul 6, 2021 · 0 comments · Fixed by #68049
Assignees
@vladlos
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@thtruo
Copy link
Contributor

thtruo commented Jul 6, 2021 •
edited by exalate-issue-sync bot
Loading

Identified by @mikeczabator

Describe the problem

The Live status should appear neutral, however it appears yellow in 21.1.5

image (17)

To Reproduce

Note: I haven't been able to reproduce it on roachprod (v21.1.5 clusters), but Michael did report seeing this happen when stopping a node on the cluster, getting it into the Suspect state (yellow), and then restart it again.

Epic CRDB-8313
@thtruo thtruo added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cluster-ui labels Jul 6, 2021
@vladlos vladlos mentioned this issue Jul 26, 2021
Merged
vladlos added a commit to vladlos/cockroach that referenced this issue Jul 26, 2021
@vladlos
ui: cluster overview node status color mismatch
d569558 
We aggreagate rows for multiregion cluster in nodes list
table and used single method to calculate status badge for
aggregated and single node row. After adding additional
node status `NODE_STATUS_DRAINING` we have got
enum values overlap and that lead to `LIVE` badge with
`warning` color.
To fix that, and avoid same problem in future, changes for
splitting up aggregated and non aggregated color values
were made.

Resolves: cockroachdb#67274

Release note(ui): fix color mismatch of node status badge
on cluster overview page.
@vladlos vladlos mentioned this issue Jul 26, 2021
Merged
craig bot pushed a commit that referenced this issue Jul 28, 2021
@vladlos
Merge #68049
5b971c2 
68049: ui: cluster overview node status color mismatch r=elkmaster a=elkmaster

We aggreagate rows for multiregion cluster in nodes list
table and used single method to calculate status badge for
aggregated and single node row. After adding additional
node status `NODE_STATUS_DRAINING` we have got
enum values overlap and that lead to `LIVE` badge with
`warning` color.
To fix that, and avoid same problem in future, changes for
splitting up aggregated and non aggregated color values
were made.

Resolves: #67274

Release note(ui); fix color mismatch of node status badge
on cluster overview page.

Co-authored-by: Vlad Los <[email protected]>
@craig craig bot closed this as completed in 43e93ee Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladlos vladlos

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: cluster overview node status color mismatch vladlos/cockroach
2 participants
@thtruo @vladlos