release-21.1: colexec: fix CASE operator a bit #67779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #67757.
/cc @cockroachdb/release
Release justification: extremely low risk fix to an edge case bug that was hit
a few times in the wild.
Whenever we're updating the length on the batch containing bytes-like
vectors, we are updating those vectors to have non-decreasing offsets.
In case the batch has a selection vector set, we're using the largest
index in the selection to update the offsets. This logic relies on the
assumption that the selection vector is set on the batch before
setting the length which wasn't the case in a couple of places.
Note that there is no regression test because I cannot quite pin down
the exact conditions for the bug to occur (we need a bytes-like vector
in the batch but also such a selection vector that has garbage values
beyond the current length of the batch).
Fixes: #67744.
Release note (bug fix): Fixed very rare unexpected error from the
vectorized engine (index out of bounds) when evaluating CASE operator.