colexec: fix CASE operator a bit #67757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Whenever we're updating the length on the batch containing bytes-like vectors, we are updating those vectors to have non-decreasing offsets. In case the batch has a selection vector set, we're using the largest index in the selection to update the offsets. This logic relies on the assumption that the selection vector is set on the batch **before** setting the length which wasn't the case in a couple of places. In particular, the recent refactor of the case operator added the support of bytes-like types as the output of the case operator, but the existing code was setting the length on the batch first. This is now fixed. Release note: None
michae2
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
|
TFTR! bors r+ |
yuzefovich
changed the title
|
Build succeeded: |
This was referenced Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we're updating the length on the batch containing bytes-like
vectors, we are updating those vectors to have non-decreasing offsets.
In case the batch has a selection vector set, we're using the largest
index in the selection to update the offsets. This logic relies on the
assumption that the selection vector is set on the batch before
setting the length which wasn't the case in a couple of places.
In particular, the recent refactor of the case operator added the
support of bytes-like types as the output of the case operator, but the
existing code was setting the length on the batch first. This is now
fixed.
Addresses: #64793 (comment).
Fixes: #67744.
Release note: None