[WIP] running replacement CI for #62435 #63033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
otan_demo_test
branch
5 times, most recently
from
d7347e8 to
239fc27
Compare
otan
reviewed
Apr 5, 2021
pkg/cli/demo_test.go
Outdated
| maxRoundTripLatency = d | ||
| } | ||
| } | ||
| defer time.Sleep(maxRoundTripLatency) |
There was a problem hiding this comment.
haha if this is it...
i had a commit that waited for 60secs earlier for leaktest and i thought i saw the same error o_o
knz
force-pushed
the
otan_demo_test
branch
3 times, most recently
from
f61df69 to
066defc
Compare
|
@otan this passes CI now with no changes to the code. I think #63853 did the trick, and we were observing golang/go#45076 before. I'll rebase this and clean it up, then you can pick it up in #62435. |
We previously had no tests simulating the latency in demo using the --global flag. Release note: None
In addition to the release note, reworded the add node (which already errored beforehand), and adding a clause in RestartNode. Note there is no code path that allows a restart, since shutdown is required before a node restart. Release note (cli change): Previously, `\demo shutdown <node_idx>` would error if `--global` was set. This will now error gracefully as an unsupported behavior.
Release note (cli change): The --global flag for cockroach demo is now advertised. This flag simulates latencies in multi-node demo clusters when the nodes are set in different regions to simulate real-life global latencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this PR are meant to replace those in #62435.