cli: fix \demo shutdown with --global #62704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Mar 28, 2021
|
wonder if this explains the leaking goroutine in #62435 (comment) .... i'll give it a shot after this merges! |
|
bors r+ |
|
bors r- |
|
Canceled. |
Previously, it crashed due to not setting up the demo's rpc context to include the artificial latency map. Release note: None
jordanlewis
force-pushed
the
fix-global-demo-shutdown
branch
from
e7e23ee to
6b1b69a
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it crashed due to not setting up the demo's rpc context to
include the artificial latency map.
Release note: None