Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix connect_privilege logic test #60544

Merged
merged 1 commit into from
Feb 12, 2021
Merged

sql: fix connect_privilege logic test #60544

merged 1 commit into from
Feb 12, 2021

Conversation

postamar
Copy link
Contributor

Previously, this logic test performed an assertion on a notice output
which contained an issue link, which isn't stable across versions.

This patch replaces the query T noticetrace matching rule with the
statement notice rule which allows for partial matching.

Release note: None

sql: fix connect_privilege logic test
a9c780c 
Previously, this logic test performed an assertion on a notice output
which contained an issue link, which isn't stable across versions.

This patch replaces the `query T noticetrace` matching rule with the
`statement notice` rule which allows for partial matching.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar marked this pull request as ready for review February 12, 2021 21:37
@postamar postamar requested a review from RichardJCai February 12, 2021 21:37
RichardJCai
RichardJCai approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@RichardJCai RichardJCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@postamar
Copy link
Contributor Author

postamar commented Feb 12, 2021 •
edited
Loading

To repro, check out master and run make testbaselogic TESTCONFIG=local FILES='connect_privilege'. @ajwerner let me know that make test PKG=./pkg/sql/logictest/ TESTS='TestLogic/local$$/connect_privilege' passes.

@postamar
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 12, 2021

Build succeeded:

@craig craig bot merged commit 0bf4147 into cockroachdb:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardJCai RichardJCai RichardJCai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@postamar @cockroach-teamcity @RichardJCai