Skip to content

Commit

Permalink
Merge #60544
Browse files Browse the repository at this point in the history
60544: sql: fix connect_privilege logic test r=postamar a=postamar

Previously, this logic test performed an assertion on a notice output
which contained an issue link, which isn't stable across versions.

This patch replaces the `query T noticetrace` matching rule with the
`statement notice` rule which allows for partial matching.

Release note: None

Co-authored-by: Marius Posta <[email protected]>
  • Loading branch information
craig[bot] and Marius Posta committed Feb 12, 2021
2 parents 98beba6 + a9c780c commit 0bf4147
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pkg/sql/logictest/testdata/logic_test/connect_privilege
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,8 @@ public a root

user testuser

query T noticetrace
statement notice NOTICE: CONNECT privilege will be required to connect to databases in a future release\nHINT: .*59875.*
use test
----
NOTICE: CONNECT privilege will be required to connect to databases in a future release
HINT: See: https://go.crdb.dev/issue-v/59875/v21.1

query TTT
SELECT schemaname, tablename, tableowner FROM pg_catalog.pg_tables WHERE tablename = 'a'
Expand Down

0 comments on commit 0bf4147

Please sign in to comment.