Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabledesc: omit implicit columns from auto-generated index names #58898

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented Jan 13, 2021

Release note (sql change): Omit the inclusion of implicit columns or
hash sharded index columns from automatically generated index names.

@otan otan requested review from ajstorm and a team January 13, 2021 00:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (sql change): Omit the inclusion of implicit columns or
hash sharded index columns from automatically generated index names.
Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Contributor Author

otan commented Jan 13, 2021

bors r=ajstorm

@craig
Copy link
Contributor

craig bot commented Jan 13, 2021

Build failed:

@otan
Copy link
Contributor Author

otan commented Jan 13, 2021

bors r=ajstorm

@craig
Copy link
Contributor

craig bot commented Jan 13, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants