Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: restart node in kv/quiesence unconditionally #55239

Merged
merged 4 commits into from
Oct 8, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
roachtest: restart node in kv/quiesence unconditionally
When the test fails, restart the node anyway, so we don't get distracted
by a faux "dead node".

Release note: None
  • Loading branch information
tbg committed Oct 6, 2020
commit 0c1b8fa819496a39000f7493dda62b4ecc4da45c
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/kv.go
Original file line number Diff line number Diff line change
@@ -328,6 +328,7 @@ func registerKVQuiescenceDead(r *testRegistry) {
// other earlier kv invocation's footsteps.
run(kv+" --seed 2 {pgurl:1}", true)
})
c.Start(ctx, t, c.Node(nodes)) // satisfy dead node detector, even if test fails below

if minFrac, actFrac := 0.8, qpsOneDown/qpsAllUp; actFrac < minFrac {
t.Fatalf(
@@ -336,7 +337,6 @@ func registerKVQuiescenceDead(r *testRegistry) {
)
}
t.l.Printf("QPS went from %.2f to %2.f with one node down\n", qpsAllUp, qpsOneDown)
c.Start(ctx, t, c.Node(nodes)) // satisfy dead node detector
},
})
}