roachtest: restart node in kv/quiesence unconditionally #55239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the test fails, restart the node anyway, so we don't get distracted by a faux "dead node". Release note: None
|
This change is |
roachtests are never invoked under race. Release note: None
It's reliably flaky. Touches cockroachdb#53811. Touches cockroachdb#54088. Touches cockroachdb#53760. Touches cockroachdb#53725. Release note: None
The consistency check could still happen at a moment at which not all nodes were live "to each other". A consistency check that skips a node is between two nodes, so a 50:50 chance of killing either. Not what we want - we want n1 to be the designated loser. Fixes cockroachdb#55205. Release note: None
|
Friendly ping. |
knz
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the test fails, restart the node anyway, so we don't get distracted
by a faux "dead node".
Release note: None