Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: show schema privileges in SHOW BACKUP #54182

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

pbardea
Copy link
Contributor

@pbardea pbardea commented Sep 10, 2020

Previously, privileges for schemas were not displayed in SHOW BACKUP.

Part of #53548.

Release note: None

Previously, privileges for schemas were not displayed in SHOW BACKUP.

Release note: None
@pbardea pbardea requested review from a team and adityamaru and removed request for a team September 10, 2020 14:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice test 😎

@pbardea
Copy link
Contributor Author

pbardea commented Sep 14, 2020

TFTRs!
bors r=adityamaru,dt

@craig
Copy link
Contributor

craig bot commented Sep 14, 2020

Build succeeded:

@craig craig bot merged commit 39cd953 into cockroachdb:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants