Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: handle schema/type privileges #53548

Closed
4 tasks done
pbardea opened this issue Aug 27, 2020 · 1 comment
Closed
4 tasks done

backupccl: handle schema/type privileges #53548

pbardea opened this issue Aug 27, 2020 · 1 comment
Assignees
@pbardea
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@pbardea
Copy link
Contributor

pbardea commented Aug 27, 2020 •
edited
Loading

There are several aspects of privileges on schemas/types that need to be addressed with respect to types/schemas:
@pbardea pbardea added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery labels Aug 27, 2020
@pbardea pbardea self-assigned this Aug 27, 2020
@pbardea pbardea mentioned this issue Sep 4, 2020
Closed
@pbardea pbardea added the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 8, 2020
This was referenced Sep 10, 2020
Merged
Merged
craig bot pushed a commit that referenced this issue Sep 14, 2020
@pbardea
Merge #54182 #54183
39cd953 
54182: backupccl: show schema privileges in SHOW BACKUP r=adityamaru,dt a=pbardea

Previously, privileges for schemas were not displayed in SHOW BACKUP.

Part of #53548.

Release note: None

54183: backupccl: check privileges on types and schemas during backup r=solongordon,dt a=pbardea

This commit adds a check that ensures that the user running the backup
has USAGE privileges on the schemas and types they're backing up.

Note that this check doesn't actually enforce anything for now since
currently BACKUP must be run by an `admin`, which has to have ALL
privileges on both types and schemas. However, this check is consistent
with the other privilege checks we have for databases and tables.

Part of #53548.

Release note: None

Co-authored-by: Paul Bardea <[email protected]>
This was referenced Sep 16, 2020
Merged
Merged
@pbardea
Copy link
Contributor Author

pbardea commented Sep 28, 2020

Point 3, was addressed and backported in #54854. Closing.

@pbardea pbardea closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbardea pbardea

Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backupccl: enum/schemas integration with privileges in BACKUP/RESTORE pbardea/cockroach
2 participants
@dt @pbardea