bulkio: Fix transaction semantics in job scheduler. #53049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Aug 19, 2020
| @@ -252,8 +254,20 @@ func (s *jobScheduler) executeSchedules( | |||
| continue | |||
| } | |||
|
|
|||
| sp, err := txn.CreateSavepoint(ctx) | |||
There was a problem hiding this comment.
@knz or @nvanbenschoten can you just double-check we're using the Savepoint API correctly?
miretskiy
force-pushed
the
scheduler_txn
branch
from
4f77599 to
3192e5c
Compare
knz
reviewed
Aug 19, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/jobs/job_scheduler.go, line 257 at r1 (raw file):
Previously, dt (David Taylor) wrote…
@knz or @nvanbenschoten can you just double-check we're using the Savepoint API correctly?
looks good
miretskiy
force-pushed
the
scheduler_txn
branch
3 times, most recently
from
c051cdd to
73f7d62
Compare
|
bors r+ |
added 2 commits
August 20, 2020 14:30
Fix show jobs delegation code to correclty handle `FOR SCHEDUL(s)` clause. Release Notes: None
Use transaction when querying for the schedules to run. In addition, ensure that a single bad schedule does not cause all of the previous work to be wasted by using transaction savepoints. Release Notes: None
miretskiy
force-pushed
the
scheduler_txn
branch
from
73f7d62 to
aab9608
Compare
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53033
Fixes #52959
Use transaction when querying for the schedules to run.
In addition, ensure that a single bad schedule does not cause
all of the previous work to be wasted by using transaction savepoints.
Release Notes: None