Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulkio: Incorrect transaction semantics in job_scheduler #53033

Closed
miretskiy opened this issue Aug 19, 2020 · 1 comment · Fixed by #53049
Closed

bulkio: Incorrect transaction semantics in job_scheduler #53033

miretskiy opened this issue Aug 19, 2020 · 1 comment · Fixed by #53049
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@miretskiy
Copy link
Contributor

Job scheduler does not use transactions correctly, and this can lead to deadlocks.
In particular, the query to find schedules to run does not use transaction; yet the updates
to schedules are done under txn. This can lead to a stuck process if the transaction retries
after any changes have been made to any of the schedules.

In addition, currently, a single schedule with any sort of error (planning, etc) would lead to the
entire scheduler loop to be undone.

@miretskiy miretskiy self-assigned this Aug 19, 2020
@blathers-crl
Copy link

blathers-crl bot commented Aug 19, 2020

Hi @miretskiy, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@miretskiy miretskiy added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 19, 2020
@craig craig bot closed this as completed in 979127c Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant