kvserver,rangefeed: ensure that iterators are only constructed under tasks #52844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/construct-iterator-under-tasks
branch
from
ffa1cc4 to
571f4be
Compare
andreimatei
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @andreimatei)
pkg/kv/kvserver/replica_rangefeed.go, line 196 at r1 (raw file):
} // Register the stream with a catch-up iterator.
I think you want to move this comment inside the new function, right?
…tasks Prior to this change, it was possible for a rangefeed request to be issued concurrently with shutting down which could lead to an iterator being constructed after the engine has been closed. Touches cockroachdb#51544 Release note: None
ajwerner
commented
Aug 19, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/kv/kvserver/replica_rangefeed.go, line 196 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
I think you want to move this comment inside the new function, right?
meh, it's the existence of the function that indicates that the stream has been registered with a catch-up iterator.
ajwerner
force-pushed
the
ajwerner/construct-iterator-under-tasks
branch
from
571f4be to
5cbf775
Compare
|
TFTR! bors r=andreimatei |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, it was possible for a rangefeed request to be issued
concurrently with shutting down which could lead to an iterator being
constructed after the engine has been closed.
Touches #51544
Release note: None