Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: panic: semaphore release without acquire #53366

Closed
maddyblue opened this issue Aug 24, 2020 · 5 comments
Closed

cdc: panic: semaphore release without acquire #53366

maddyblue opened this issue Aug 24, 2020 · 5 comments
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered).

Comments

@maddyblue
Copy link
Contributor

Test flake?

=== RUN   TestChangefeedNemeses/sinkless
panic: semaphore release without acquire [recovered]
  panic: semaphore release without acquire
goroutine 218102 [running]:
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).Recover(0xc00209c240, 0x5c2ff60, 0xc001494740)
  /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:207 +0x11f
panic(0x44e0a40, 0x5b3b180)
  /usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/marusama/semaphore.(*semaphore).Release(0xc003d35e60, 0x1, 0xc001d26000)
  /go/src/github.com/cockroachdb/cockroach/vendor/github.com/marusama/semaphore/semaphore.go:170 +0x11d
github.com/cockroachdb/cockroach/pkg/util/limit.(*ConcurrentRequestLimiter).Finish(...)
  /go/src/github.com/cockroachdb/cockroach/pkg/util/limit/limiter.go:54
github.com/cockroachdb/cockroach/pkg/kv/kvserver.iteratorWithCloser.Close(0x5c86b40, 0xc001d26000, 0xc009813150)
  /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/replica_rangefeed.go:120 +0x3b
github.com/cockroachdb/cockroach/pkg/kv/kvserver/rangefeed.(*registration).maybeRunCatchupScan.func1(0x5c87500, 0xc002a32dc0, 0xc001091ea0, 0x2453900d, 0xed6d61674, 0x0)
  /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/rangefeed/registry.go:290 +0x31
github.com/cockroachdb/cockroach/pkg/kv/kvserver/rangefeed.(*registration).maybeRunCatchupScan(0xc001091ea0, 0x0, 0x0)
  /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/rangefeed/registry.go:411 +0xe22

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests/2217816?
@maddyblue maddyblue added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). A-cdc Change Data Capture labels Aug 24, 2020
@irfansharif
Copy link
Contributor

I have a somewhat reliable repro for this running https://github.com/cockroachdb/cockroach/pull/52526/files#diff-3d4bd4076f3843bd43527cb196fb5d06R35-R39. I can polish it up for others if hard to repro through if TestChangefeedNemeses is not reliable enough for it.

@irfansharif
Copy link
Contributor

+cc @mwang1026.

@irfansharif
Copy link
Contributor

@ajwerner know anything about this? I see you were in the area as of #52844.

@ajwerner
Copy link
Contributor

This was introduced in #52844 but should have been fixed by #53295.

@ajwerner
Copy link
Contributor

I'm going to close this as I do think #53295 fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maddyblue @ajwerner @irfansharif