Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: change label on printed build revision, Release note: none #52259

Closed
wants to merge 1 commit into from
Closed

cli: change label on printed build revision, Release note: none #52259

wants to merge 1 commit into from

Conversation

dbist
Copy link
Contributor

@dbist dbist commented Aug 3, 2020

addresses #52249

@dbist dbist requested a review from a team as a code owner August 3, 2020 17:21
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dbist dbist requested a review from dt August 3, 2020 17:22
@knz
Copy link
Contributor

knz commented Aug 3, 2020

Thanks for the change. Can you preserve the vertical alignment that was achieved in the previous code?

@dbist dbist self-assigned this Aug 3, 2020
@knz
Copy link
Contributor

knz commented Aug 3, 2020

The text "Release note: none" must be present in the commit message, on a line of its own, at the end.

Currently you put it in the PR title. That's not the right place.

@knz
Copy link
Contributor

knz commented Aug 3, 2020

Also I believe @dt gave you a concrete release note to mention here.

@dbist dbist mentioned this pull request Aug 3, 2020
Merged
@dbist dbist closed this Aug 3, 2020
@dbist dbist deleted the issue-52249 branch August 3, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt dt Awaiting requested review from dt

Assignees

@dbist dbist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbist @cockroach-teamcity @knz