cli: replace SHA-1 with build commit ID #52249
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
|
Hi @dbist, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate. While you're here, please consider adding an A- label to help keep our repository tidy. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
blathers-crl
bot
added
the
C-enhancement
|
tests pass locally, cockroach git:(issue-52249) ✗ make test PKG=./pkg/cli
Running make with -j16
GOPATH set to /Users/artem/go
mkdir -p lib
rm -f lib/lib{geos,geos_c}.dylib
cp -L /Users/artem/go/native/x86_64-apple-darwin19.6.0/geos/lib/lib{geos,geos_c}.dylib lib
GOFLAGS= go test -mod=vendor -tags ' make x86_64_apple_darwin19.6.0' -ldflags '-X github.com/cockroachdb/cockroach/pkg/build.typ=development -extldflags "" -X "github.com/cockroachdb/cockroach/pkg/build.tag=v20.2.0-alpha.1-1697-g470510ed00-dirty" -X "github.com/cockroachdb/cockroach/pkg/build.rev=470510ed00ee0261ecede8daf0b9392f0526a0a0" -X "github.com/cockroachdb/cockroach/pkg/build.cgoTargetTriple=x86_64-apple-darwin19.6.0" ' -run "." -timeout 30m ./pkg/cli
ok github.com/cockroachdb/cockroach/pkg/cli 240.110s |
This was referenced Aug 3, 2020
Closed
craig bot
pushed a commit
that referenced
this issue
Aug 4, 2020
50265: kvserver: prevent follower reads while a range is subsumed r=nvanbenschoten,andreimatei a=aayushshah15 Before this commit, during a merge, the RHS leaseholder’s store could continue broadcasting (actionable) closed timestamp updates even after it had been subsumed. This allowed the followers to be able to serve follower reads past the subsumption time of RHS. Additionally, after the merge, if the LHS had a lower closed timestamp than the RHS, it could allow writes to the keyspan owned by RHS at timestamps lower than the RHS’s max closed timestamp. This commit fixes this bug by requiring that the followers catch up to a LeaseAppliedIndex that belongs to the entry succeeding the Subsume request. Fixes #44878 Release note (bug fix): Fixed a rare bug that could cause actionable closed timestamps to effectively regress over a given keyspan. This could in turn lead to a serializability violation when using follower reads. This was due to ill-defined interactions between range merges and the closed timestamp subsystem. 52241: backupccl: direct spans after split and scatter r=pbardea a=pbardea The AdminScatter request sent in the SplitAndScatterProcessor returns the lease information of the range after the scatter requst has completed. The SplitAndScatterProcessor now looks at this field to properly direct the spans to the appropriate RestoreData processor. Release note: None. 52263: cli: change label on printed build revision r=dt a=dbist Fixes #52249 Release note (cli change): update label used for commit ID in printed version info Co-authored-by: Aayush Shah <[email protected]> Co-authored-by: Paul Bardea <[email protected]> Co-authored-by: Artem Ervits <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The current CLI displays git commit hash with build SHA-1 which may be confusing and raise additional questions.
Describe the solution you'd like
Replace with
Build Commit IDinstead.Describe alternatives you've considered
N/A
Additional context
The text was updated successfully, but these errors were encountered: