release-20.1: server: fix bug where SQL stats were not flushed into reportable stats #52072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I forgot to backport this :( |
Touches cockroachdb#49388. This was caused by the background loops use an incorrect setup to reset collected stats. Also, fix a bug where statements issued at the same time that the SQL stats are flushed would not be reported. Release note: None
rohany
force-pushed
the
backport20.1-49392
branch
from
672122a to
d1aea9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #49392.
/cc @cockroachdb/release
Fixes #49388.
This was caused by the background loops use an incorrect setup to reset
collected stats.
Also, fix a bug where statements issued at the same time that the SQL
stats are flushed would not be reported.
Release note: None