sql: sqlstats is missing on v20.1.0 #49388
Assignees
Labels
A-telemetry
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
DuskEagle
added
the
C-bug
rohany
added a commit
to rohany/cockroach
that referenced
this issue
May 28, 2020
Touches cockroachdb#49388. This was caused by the background loops use an incorrect setup to reset collected stats. Also, fix a bug where statements issued at the same time that the SQL stats are flushed would not be reported. Release note: None
rohany
added a commit
to rohany/cockroach
that referenced
this issue
May 28, 2020
Touches cockroachdb#49388. This was caused by the background loops use an incorrect setup to reset collected stats. Also, fix a bug where statements issued at the same time that the SQL stats are flushed would not be reported. Release note: None
craig bot
pushed a commit
that referenced
this issue
May 28, 2020
49392: server: fix bug where SQL stats were not flushed into reportable stats r=knz a=rohany Touches #49388. This was caused by the background loops use an incorrect setup to reset collected stats. Also, fix a bug where statements issued at the same time that the SQL stats are flushed would not be reported. Release note: None Co-authored-by: Rohan Yadav <[email protected]>
|
@DuskEagle / @rohany I see a PR was merged for this, does that mean we are collecting stats again? Can we backfill the missed dates or no? Thanks :) |
|
We'll have to wait for 20.1.2 to go out with this fix before we start getting stats again. Sadly I don't think we can backfill the missing dates. |
jbowens
pushed a commit
to jbowens/cockroach
that referenced
this issue
Jun 1, 2020
Touches cockroachdb#49388. This was caused by the background loops use an incorrect setup to reset collected stats. Also, fix a bug where statements issued at the same time that the SQL stats are flushed would not be reported. Release note: None
|
this issue is fixed by #49392 isn't it? |
|
I think so, but I'd like to wait for a 20.1.2 rc that I know works before closing. |
rohany
added a commit
to rohany/cockroach
that referenced
this issue
Jul 29, 2020
Touches cockroachdb#49388. This was caused by the background loops use an incorrect setup to reset collected stats. Also, fix a bug where statements issued at the same time that the SQL stats are flushed would not be reported. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
SQL stats are being reported on v20.1 clusters. The sqlstats appear as an empty list even when stats should be present.
To Reproduce
Visit the the
/_status/diagnostics/localpage of a v20.1 cluster, and view thesqlStatsentry.Expected behavior
SQL stats appear in the sqlStats entry on
/_status/diagnostics/local. This is the behaviour on versions of CockroachDB <= v19.2.Additional context
This affects all telemetry collection of SQL statements on v20.1 clusters. We have no stats on what types of queries are being run on v20.1 until this is fixed.
The text was updated successfully, but these errors were encountered: