colexec: fix resetting of the hashtable with distinct build mode #50247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Thanks to the change of random batch size distribution, I was able to easily reproduce the second failure from #50006 which made debugging the issue a lot easier. |
Some time ago we introduced "distinct" build mode to the hash table which is used by the unordered distinct. In that addition we forgot to add one thing to be reset whenever the hash table is reset which causes partially ordered distinct to behave incorrectly. The damage, however, is negligible because the bug doesn't affect "default" build mode nor unordered distinct as is, only when we have partially ordered distinct which uses the unordered distinct internally and resets it between different "chunks". And we don't currently plan partially ordered distinct, so only our unit tests are able to hit it, and there is no need for a backport. Release note: None
yuzefovich
force-pushed
the
hashtable-reset
branch
from
4124320 to
e7ca8ca
Compare
asubiotto
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
|
TFTR! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago we introduced "distinct" build mode to the hash table
which is used by the unordered distinct. In that addition we forgot to
add one thing to be reset whenever the hash table is reset which causes
partially ordered distinct to behave incorrectly. The damage, however,
is negligible because the bug doesn't affect "default" build mode nor
unordered distinct as is, only when we have partially ordered distinct
which uses the unordered distinct internally and resets it between
different "chunks". And we don't currently plan partially ordered
distinct, so only our unit tests are able to hit it, and there is no
need for a backport.
Fixes: #50006.
Release note: None