Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/colexec: TestDistinct failed #50006

Closed
cockroach-teamcity opened this issue Jun 9, 2020 · 3 comments · Fixed by #50247
Closed

sql/colexec: TestDistinct failed #50006

cockroach-teamcity opened this issue Jun 9, 2020 · 3 comments · Fixed by #50247
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(sql/colexec).TestDistinct failed on master@3c756942000f7c2292ed1c3e68f78aa1d9f33dd2:

=== RUN   TestDistinct
--- FAIL: TestDistinct (0.11s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false (0.00s)
            utils_test.go:382: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true (0.00s)
            utils_test.go:382: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01
    --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01 (0.00s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false (0.00s)
            utils_test.go:382: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true (0.00s)
            utils_test.go:382: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestDistinct PKG=./pkg/sql/colexec TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jun 9, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Jun 9, 2020
@cockroach-teamcity
Copy link
Member Author

(sql/colexec).TestDistinct failed on master@13356765ce742e90a1abd274f7862d46f687cead:

=== RUN   TestDistinct
--- FAIL: TestDistinct (0.22s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1/batchSize=3/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1/batchSize=3/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1/batchSize=3/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1/batchSize=3/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1
    --- FAIL: TestDistinct/partiallyOrdered/ordCols=1 (0.00s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01
    --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01 (0.00s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1/batchSize=1/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1/batchSize=1/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1/batchSize=1/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1/batchSize=1/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDistinct PKG=./pkg/sql/colexec TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@yuzefovich yuzefovich mentioned this issue Jun 15, 2020
Merged
@cockroach-teamcity
Copy link
Member Author

(sql/colexec).TestDistinct failed on master@9eea0be192499fa7d29b5eca5ed14173982b25f0:

=== RUN   TestDistinct
--- FAIL: TestDistinct (0.11s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01
    --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01 (0.00s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestDistinct PKG=./pkg/sql/colexec TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(sql/colexec).TestDistinct failed on master@9eea0be192499fa7d29b5eca5ed14173982b25f0:

=== RUN   TestDistinct
--- FAIL: TestDistinct (0.33s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01
    --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01 (0.01s)
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=1/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=false (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
=== RUN   TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true
        --- FAIL: TestDistinct/partiallyOrdered/ordCols=1#01/batchSize=3/sel=true (0.00s)
            utils_test.go:383: expected [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4]], actual [[<nil>, <nil>, <nil>, <nil>], [<nil>, <nil>, 30, <nil>], [1, 2, 30, 4], [2, 2, 30, 4], [2, 3, 30, 4], [2, 3, 40, 4], [2, 3, 40, 4]]
More

Parameters:

  • TAGS=
  • GOFLAGS=-race -parallel=2
make stressrace TESTS=TestDistinct PKG=./pkg/sql/colexec TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@craig craig bot closed this as completed in b3069bd Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

colexec: fix resetting of the hashtable with distinct build mode yuzefovich/cockroach
2 participants
@yuzefovich @cockroach-teamcity