build: map in the full teamcity alternates directory #47799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
jordanlewis
reviewed
Apr 21, 2020
|
|
||
| teamcity_alternates="/home/agent/system/git/" | ||
| if test -d "${teamcity_alternates}"; then | ||
| vols="${vols} --volume=${teamcity_alternates}:${teamcity_alternates}${cached_volume_mode}" |
There was a problem hiding this comment.
Could we dirname the result of the previous version? I think that would do the trick without being as TC specific.
There was a problem hiding this comment.
So alternates_path=$(dirname $(cat "${alternates_file}"))
There was a problem hiding this comment.
Probably. I'm just looking for the sledgehammer fix here. We can follow-up with a cleaner fix if this PR actually works.
I think we could also look for alternates files in other .git directories.
|
Some of the bors r+ |
Build failed |
|
Examples-ORMs failure. Hoping it was just a flake. bors r+ |
Build succeeded |
This was referenced Apr 22, 2020
This was referenced Apr 22, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None