release-20.1: cli: Support cluster name flags in all non-sql client commands #48016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless I'm missing something, the cluster-name functionality is pretty broken without the ability to use all the various client commands on clusters that have a name. I was trying out some new features today and couldn't figure out any supported way to do basic operations on a node that was using a cluster-name. It seemed easy enough to fix, so here we are. I'm not at all tied to to including both the --cluster-name and --disable-cluster-name-verification flags, but at first glance it seemed useful to include both. I didn't include any error cases in the tcl test because I didn't want to have to figure out the correct tcl for dealing with the fact that the commands hang in a seemingly infinite retry loop when the cluster-name is missing/incorrect. Fixes cockroachdb#40437 Release note (cli change): Client commands such as init and quit now support the --cluster-name and --disable-cluster-name-verification flags in order to support running them on clusters that have been configured to use a cluster name. Previously it was impossible to run such commands against nodes configured with the --cluster-name flag.
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
|
LGTM |
|
please hold off on merging this until the final release SHA is selected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #48000.
/cc @cockroachdb/release
Release note (cli change): Client commands such as init and quit now
support the --cluster-name and --disable-cluster-name-verification flags
in order to support running them on clusters that have been configured
to use a cluster name. Previously it was impossible to run such
commands against nodes configured with the --cluster-name flag.