release-20.1: sql: Change output of CREATE/ALTER/DROP ROLE to not include rows affected. Add hint for GRANT ROLE. #46819
Conversation
|
This change is |
|
Can you fix the subject line of the commit message. right now it spans two lines |
There was a problem hiding this comment.
Please also add the examples from the PR description into the commit message. That's where they belong.
I also vaguely recall I have reviewed this PR already somewhere - did you create a new one?
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
did you use the |
RichardJCai
force-pushed
the
backport20.1-46795
branch
from
02ac7a5 to
55e8f2a
Compare
Sorry, I didn't know about the backport tool - updated to use it. |
|
do you still need a review on this one? |
|
Yeah, or rather need approval to backport it. |
|
ok then can you update the PR description and rebase, then i'll review |
RichardJCai
force-pushed
the
backport20.1-46795
branch
from
55e8f2a to
9ca5536
Compare
… Add hint for GRANT ROLE. Fixes cockroachdb#46728, cockroachdb#46698 Release note (sql change): Remove rows affected from CREATE/ALTER/DROP ROLE command results. The number doesn't make sense to include since rows affected includes system.role_options rows, this number can be misleading (ie CREATE ROLE returning 3). This also matches PG as no number is returned for these commands. Release note (sql change): Add hint to use ALTER ROLE when trying to "GRANT" a role option directly to a user (using the GRANT ROLE syntax). Release justification: Low risk change, command result output changed for CREATE/ALTER/DROP ROLE. Hint added for GRANT ROLE.
RichardJCai
changed the title
Rebased and updated |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
TFTR! |
|
i think you need to retry this. |
|
bors r=knz |
Build failed |
|
Retrying again - failure doesn't look related to change. bors r=knz |
46819: release-20.1: sql: Change output of CREATE/ALTER/DROP ROLE to not include rows affected. Add hint for GRANT ROLE. r=knz a=RichardJCai Backport 1/1 commits from #46795. /cc @cockroachdb/release Co-authored-by: Richard Cai <[email protected]>
|
bors r=knz |
Build succeeded |
Backport 1/1 commits from #46795.
/cc @cockroachdb/release