sql:Remove number from CREATE/ALTER/DROP ROLE response #46728
Assignees
Labels
A-sql-privileges
SQL privilege handling and permission checks.
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
RichardJCai
added
C-enhancement
RichardJCai
added a commit
to RichardJCai/cockroach
that referenced
this issue
Mar 31, 2020
… Add hint for GRANT ROLE. Fixes cockroachdb#46728, cockroachdb#46698 Release note (sql change): Remove rows affected from CREATE/ALTER/DROP ROLE command results. The number doesn't make sense to include since rows affected includes system.role_options rows, this number can be misleading (ie CREATE ROLE returning 3). This also matches PG as no number is returned for these commands. Release note (sql change): Add hint to use ALTER ROLE when trying to "GRANT" a role option directly to a user (using the GRANT ROLE syntax). Release justification: Low risk change, command result output changed for CREATE/ALTER/DROP ROLE. Hint added for GRANT ROLE.
RichardJCai
added a commit
to RichardJCai/cockroach
that referenced
this issue
Mar 31, 2020
… Add hint for GRANT ROLE. Fixes cockroachdb#46728, cockroachdb#46698 Release note (sql change): Remove rows affected from CREATE/ALTER/DROP ROLE command results. The number doesn't make sense to include since rows affected includes system.role_options rows, this number can be misleading (ie CREATE ROLE returning 3). This also matches PG as no number is returned for these commands. Release note (sql change): Add hint to use ALTER ROLE when trying to "GRANT" a role option directly to a user (using the GRANT ROLE syntax). Release justification: Low risk change, command result output changed for CREATE/ALTER/DROP ROLE. Hint added for GRANT ROLE.
RichardJCai
added a commit
to RichardJCai/cockroach
that referenced
this issue
Mar 31, 2020
… Add hint for GRANT ROLE. Fixes cockroachdb#46728, cockroachdb#46698 Release note (sql change): Remove rows affected from CREATE/ALTER/DROP ROLE command results. The number doesn't make sense to include since rows affected includes system.role_options rows, this number can be misleading (ie CREATE ROLE returning 3). This also matches PG as no number is returned for these commands. Release note (sql change): Add hint to use ALTER ROLE when trying to "GRANT" a role option directly to a user (using the GRANT ROLE syntax). Release justification: Low risk change, command result output changed for CREATE/ALTER/DROP ROLE. Hint added for GRANT ROLE.
RichardJCai
added a commit
to RichardJCai/cockroach
that referenced
this issue
Apr 6, 2020
… Add hint for GRANT ROLE. Fixes cockroachdb#46728, cockroachdb#46698 Release note (sql change): Remove rows affected from CREATE/ALTER/DROP ROLE command results. The number doesn't make sense to include since rows affected includes system.role_options rows, this number can be misleading (ie CREATE ROLE returning 3). This also matches PG as no number is returned for these commands. Release note (sql change): Add hint to use ALTER ROLE when trying to "GRANT" a role option directly to a user (using the GRANT ROLE syntax). Release justification: Low risk change, command result output changed for CREATE/ALTER/DROP ROLE. Hint added for GRANT ROLE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently after a success from any of the CREATE/ALTER/DROP ROLE commands, it returns the number of rows affected which includes number of options inserted into the system.role_options table - this is somewhat misleading as the number doesn't really make sense to the user.
Example
Goal: Change this to match postgres, have no number.
The text was updated successfully, but these errors were encountered: