Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Default sort by Execution Count column for Statements #46780

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Mar 31, 2020

Resolves: #46427

Before, default sorting was set to Latency column in
Statements page that was unintuitive.
Now it is sorted by Execution count column.

Release note (admin ui change): Change default sorting column on Statements
page to Execution Count

Release justification: bug fixes and low-risk updates to new functionality

Screenshot 2020-03-31 at 14 56 52

@koorosh koorosh requested a review from a team March 31, 2020 11:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh force-pushed the ui-statements-page--default-order branch from 979e264 to c4f0e3b Compare March 31, 2020 13:01
Before, default sorting was set to Latency column in
Statements page that was unintuitive.
Now it is sorted by Execution count column.

Release note (admin ui change): Change default sorting column on Statements
page to Execution Count

Release justification: bug fixes and low-risk updates to new functionality
@koorosh koorosh force-pushed the ui-statements-page--default-order branch from c4f0e3b to 5c47160 Compare March 31, 2020 13:02
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I think the prior comment had become false. The 7th column was the diagnostics activation which is why the sort was misbehaving perhaps.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@dhartunian
Copy link
Collaborator

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 31, 2020

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: statements page default sort by time column not visible
3 participants