Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: statements page default sort by time column not visible #46427

Closed
irfansharif opened this issue Mar 23, 2020 · 4 comments · Fixed by #46780
Closed

ui: statements page default sort by time column not visible #46427

irfansharif opened this issue Mar 23, 2020 · 4 comments · Fixed by #46780

Comments

@irfansharif
Copy link
Contributor

It seems the UI page sorts by recency by default. It's not obvious that this is what's being sorted by, and if I change the sort order I'm not sure if I can reconstruct what was there before (short of relying on #45404 being yet unsolved). I'm also not sure that makes sense as a default to sort by, for any reasonable application the statements page is going to show a random assortment of queries at the point in time of the request. That doesn't seem entirely useful to me.

@irfansharif
Copy link
Contributor Author

Assigning Piyush for triage.

@piyush-singh
Copy link

The sort behavior did change here as I don't think we display the old "time" column any more (which was execution count * mean latency, so total execution time). I'd prefer us to sort using an existing column on the page, latency seems like the next most obvious choice. cc @Annebirzin

@irfansharif
Copy link
Contributor Author

irfansharif commented Mar 23, 2020 via email

@piyush-singh
Copy link

Let's go with execution count here to Irfan's point. Adding to release blockers because default sort behavior is not obvious at all today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants