-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: statements page default sort by time column not visible #46427
Comments
Assigning Piyush for triage. |
The sort behavior did change here as I don't think we display the old "time" column any more (which was execution count * mean latency, so total execution time). I'd prefer us to sort using an existing column on the page, latency seems like the next most obvious choice. cc @Annebirzin |
Uneducated opinion but I think execution count could be a sane default.
It's the probably surfaces the "most likely" statement anyone is looking
for.
…On Mon, Mar 23, 2020, 6:06 PM Piyush Singh ***@***.***> wrote:
The sort behavior did change here as I don't think we display the old
"time" column any more (which was execution count * mean latency, so total
execution time). I'd prefer us to sort using an existing column on the
page, latency seems like the next most obvious choice. cc @Annebirzin
<https://github.com/Annebirzin>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46427 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQMN4RLFDMSDSXVQHW3TSLRI7MNZANCNFSM4LSCPXIQ>
.
|
Let's go with execution count here to Irfan's point. Adding to release blockers because default sort behavior is not obvious at all today |
It seems the UI page sorts by recency by default. It's not obvious that this is what's being sorted by, and if I change the sort order I'm not sure if I can reconstruct what was there before (short of relying on #45404 being yet unsolved). I'm also not sure that makes sense as a default to sort by, for any reasonable application the statements page is going to show a random assortment of queries at the point in time of the request. That doesn't seem entirely useful to me.
The text was updated successfully, but these errors were encountered: